-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve deprecation warnings for sass #2118
Conversation
There are still deprecation warnings for glide. As it it beyond our control I guess we'll have to accept it. But is it really necessary to rebuild the stylesheets for glide? The npm package contains pre-built stylesheets, why are we not using them? When I test to import the pre-built css-files I get the same output in style.css except that some classes have color There is an issue logged for this in the glide repo: glidejs/glide#704 |
The glide stuff aside, this PR does not produce the same CSS as before. Basically all definitions have lost a top level selector, either Before: .o-ui .rounded {
border-radius: 0.25rem;
overflow: hidden;
} After: .rounded {
border-radius: 0.25rem;
overflow: hidden;
} Before: .o-map svg,
.o-map object {
width: 100%;
} After: svg,
object {
width: 100%;
} |
Do I have to edit every scss file and add the scope to all that had it before or are I'm missing something? |
I surely am no export in CSS nor SASS, but from the looks of it, it is only the SASS See example at https://sass-lang.com/documentation/at-rules/use/, look at the 'Loading Members' example. Have you tried the SASS migrator? |
Now it produces correct stylesheet, had to use correct syntax for the nested imports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It produces a byte exact result (except for a comment). Probably could have fixed the glide stuff as well, but I don't know if there is a special reason for including the scss instead of the pre built css, so we'll leave it for now. Better merge before the conflicts pile up.
Had to move import order to avoid a warning to last, so comment moved. |
Fixes #2117